Handle React.ReactChild correctly
#402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrambeau
commented
Aug 2, 2023
...rge-cli/src/steps/serialization/component/implementation/typescript/property/type/checker.ts
Show resolved
Hide resolved
Evomatic
reviewed
Aug 3, 2023
|
I tested the dev package that you released and everything seems to work!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Altassian Design system uses
React.ReactChildfor some properties,iconAfterof<Button>component for example: https://atlassian.design/components/button/examplesCurrently it does not show up correctly in Merge, a yellow warning is displayed because the type is serialized incorrectly as
any,This PR fixes the behavior to handle
React.ReactChildas if it was aReact.ReactNode, which is the usual way to handle React nodes.It requires an upgrade of TypeScript.
I was really surprised that the upgrade of TypeScript didn't break anything 😅 !
This PR includes some refactoring to gather all the tiny functions about types in a single file, because I didn't want to add an extra file just for the new function
isAny.How to test
Run experimental mode from Altassian DS repo: https://github.com/uxpin-merge/atlas-uxpin-merge
Check that both
childrenandiconfields are displayed correctlyScreenshot